Where did diff coverage UI go? | Voters

Where did diff coverage UI go?

complete

invisig0th

My ( and many others ) primary use case used to be to review PR deltas for where coverage should be made better. The updated UI completely removed this critical capability. Can we expect this to come back or should we find a new solution?

November 8, 2022

AJ Fazzio

marked this post as

complete

AJ Fazzio

marked this post as

in progress

AJ Fazzio

invisig0th Can you tell me specifically what your workflow was? I want to make sure I fully understand what functionality has been removed. I'm also open to chat on the phone if that would be easier.

invisig0th

Heya AJ Fazzio! It was to review specifically the diff and see the coverage shortfalls within the newly introduced code so we could target those spots in unit tests. The current view seems to show files with no changes and/or no coverage changes (0.0%). We've also been seeing files report coverage changes lately that could not have changed due to the code changes in the PR. Any ideas?

AJ Fazzio

invisig0th: Got it! So, two parts to this:
Part 1: There are generally two categories of coverage changes used to determine "impacted" files in Codecov, diff (or patch) coverage changes (lines changed by the diff that have coverage info, which is what you're looking for) and indirect coverage changes. Indirect changes are changes in coverage that are a result of something other than the diff. For example, if my whole test suite is two coverage reports and I upload two coverage reports on the base and then only one coverage report on the head of a PR, I'll see a drop in coverage coming from those indirect coverage changes because I'm not uploading coverage to much of my code, unlike the base. That's despite me not changing any of that covered code. 
The way to help get around this is to sort by "patch %" by clicking on that column header in the PR view. This bubbles up those diff changes to the top. 
Part 2: You shouldn't need to sort to understand what is your diff coverage changes and what isn't, we've got a number of tweaks to the PR page that should make this not only clearer, but easier to get to the information that you need to focus on without the noise. These will rollout over the next couple months, we know the current experience can be better and we're working to get it there.

AJ Fazzio

invisig0th: Hi! It has been awhile, but I wanted to follow up, we've made a ton of changes to both the PR page and the Commits page and I'd love to hear if you have any thoughts on the changes we made. Are you able to work the way you need again within Codecov?

invisig0th

AJ Fazzio: Thanks for the follow-up! Yep! More recent changes have made the behavior i was looking for available again. Thanks!

invisig0th

Also open to the "you're holding it wrong" answer. We just need an easy way to do what was already easy in the previous version of the UI.